Re: "openssl" should not be optional - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: "openssl" should not be optional
Date
Msg-id EB87D949-F9D4-4A8E-B003-BB0C18848F83@yesql.se
Whole thread Raw
In response to Re: "openssl" should not be optional  (Christoph Berg <myon@debian.org>)
Responses Re: "openssl" should not be optional
List pgsql-hackers
> On 24 Sep 2025, at 13:37, Christoph Berg <myon@debian.org> wrote:
>
> Re: Daniel Gustafsson
>> It seems a bit restrictive to require the openssl binary which is test-only,
>> since we allow building with ssl but without TAP support (which is where the
>> openssl binary is used).
>
> Ok, but then the error messages should be better. This was found
> because a fellow Debian developer was smart enough to spot the extra
> space in that " x509" error message... (And another one knew about
> this difference between the different build environments.)

If we make it optional and skip the relevant tests then there wouldn't be any
errors messages?  I do agree that all messaging around should be very clear
though, so it's obvious why tests were skipped.

Do you feel like expanding your patch or should I?

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Proposal: Conflict log history table for Logical Replication
Next
From: Christoph Berg
Date:
Subject: Re: "openssl" should not be optional