Re: Use proc_exit() in WalRcvWaitForStartPosition - Mailing list pgsql-hackers

From Chao Li
Subject Re: Use proc_exit() in WalRcvWaitForStartPosition
Date
Msg-id E2D69547-B593-4899-95DE-1F46F7E14588@gmail.com
Whole thread Raw
In response to Re: Use proc_exit() in WalRcvWaitForStartPosition  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers

> On Apr 10, 2026, at 22:17, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Fri, Apr 10, 2026 at 4:07 PM Chao Li <li.evan.chao@gmail.com> wrote:
>> PFA v2 - updated header comment of walreceive.c. I tried to avoid mentioning the exact exit value in the comment, so
Ijust changed “exit(0)” to “terminate”. 
>
> Thanks for updating the patch!
>
> "termination instructs XXX to terminate" sounds a bit redundant. How
> about saying
> "to ereport(FATAL)" instead of “to terminate”?
>
> Regards,
>
>
> --
> Fujii Masao


Okay, yes, that was a bit redundant. I changed it to “to ereport(FATAL)” in v3.

After that change, the line went over 80 columns, so I also adjusted a few nearby lines to keep everything within the
80-columnlimit. There is no content change. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/





Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Use stack allocated StringInfoDatas, where possible (round 2)
Next
From: David Rowley
Date:
Subject: Re: Small and unlikely overflow hazard in bms_next_member()