Request a Demo
Home   >   mailing lists

Re: Use proc_exit() in WalRcvWaitForStartPosition - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Use proc_exit() in WalRcvWaitForStartPosition
Date
Msg-id CAHGQGwHdqm5CCqiTR+Dpkr2maKCSVEPyoCOuB8WMHorDsGUeTw@mail.gmail.com
Whole thread Raw
In response to Re: Use proc_exit() in WalRcvWaitForStartPosition  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Tree view 
On Fri, Apr 10, 2026 at 4:07 PM Chao Li <li.evan.chao@gmail.com> wrote:
> PFA v2 - updated header comment of walreceive.c. I tried to avoid mentioning the exact exit value in the comment, so
Ijust changed “exit(0)” to “terminate”. 

Thanks for updating the patch!

"termination instructs XXX to terminate" sounds a bit redundant. How
about saying
"to ereport(FATAL)" instead of “to terminate”?

Regards,


--
Fujii Masao

pgsql-hackers by date:

Previous
From: Ayush Tiwari
Date:
Subject: Re: [PATCH] Fix NULL dereference in pg_get_database_ddl()
Next
From: Andres Freund
Date:
Subject: Documenting coding style