Fix tuple search during apply after concurrent index DDL.
When searching the local relation by index, the apply worker can use the
first match only if the index is the relation's replica identity or
primary key. Otherwise, every match must be compared with the search slot.
Only the index OID was saved in the relation map, so this was determined
again during the search. Concurrent DROP INDEX or REINDEX can change the
index status between these two checks, causing the tuple search to fail
and the change to be silently skipped as an update_missing conflict.
Fix this by recording the answer as idxisreplident in the relation map
entry and avoid getting it second time in FindReplTupleInLocalRel() and
RelationFindReplTupleByIndex().
Oversight in 89e46da5e5.
Author: Mikhail Nikalayeu <mihailnikalayeu@gmail.com>
Author: vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Reviewed-by: Zhijie Hou <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/CADzfLwUJovFcnknCC9wjZKECX9xecgnGzC2r2TMV8h4QDD_jwQ@mail.gmail.com
Backpatch-through: 16, where it was introduced
Branch
------
REL_18_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/af48a67026145bd02fa953524fcdb0d84c1d9de6
Modified Files
--------------
src/backend/executor/execReplication.c | 37 ++++--
src/backend/replication/logical/conflict.c | 4 +
src/backend/replication/logical/relation.c | 18 ++-
src/backend/replication/logical/worker.c | 85 ++++++++------
src/include/executor/executor.h | 5 +
src/include/replication/logicalrelation.h | 4 +
src/test/subscription/Makefile | 4 +-
src/test/subscription/meson.build | 5 +-
src/test/subscription/t/032_subscribe_use_index.pl | 127 +++++++++++++++++++++
9 files changed, 239 insertions(+), 50 deletions(-)
