pgsql: Prevent remote notices from repeating local query details in log - Mailing list pgsql-committers

From Fujii Masao
Subject pgsql: Prevent remote notices from repeating local query details in log
Date
Msg-id E1xB84S-00000001aPH-33Qc@gemulon.postgresql.org
Whole thread
List pgsql-committers
Prevent remote notices from repeating local query details in logs

Since 112faf1378ee, NOTICE, WARNING, and similar messages received through
dblink, postgres_fdw, and replication connections have been logged with
ereport(LOG). With the default log_min_error_statement setting, each
such log entry can also include the current local SQL statement. An active
error-context callback can add local CONTEXT information as well. Repeating
these fields for every remote message increases log volume and processing
overhead.

Use errhidestmt() and errhidecontext() when logging these messages to
prevent the local STATEMENT and CONTEXT fields, when present, from being
repeated for each remote message in the server log.

Reported-by: Merlin Moncure <mmoncure@gmail.com>
Author: Vignesh C <vignesh21@gmail.com
Reviewed-by: Merlin Moncure <mmoncure@gmail.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CAHyXU0yDwOYkWpRi=gtpDwjBxVqeaezgkgZLRWm2p1_FgaiPFQ@mail.gmail.com
Backpatch-though: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/23da62e98a7c33977134e8d0318d109fca3a8954

Modified Files
--------------
src/include/libpq/libpq-be-fe-helpers.h | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Fujii Masao
Date:
Subject: pgsql: Prevent remote notices from repeating local query details in log
Next
From: Amit Kapila
Date:
Subject: pgsql: Fix tuple search during apply after concurrent index DDL.