pgsql: Speed up pg_waldump TAP test - Mailing list pgsql-committers

From Michael Paquier
Subject pgsql: Speed up pg_waldump TAP test
Date
Msg-id E1x1Yhu-000000036Sy-3Dkp@gemulon.postgresql.org
Whole thread
List pgsql-committers
Speed up pg_waldump TAP test

Several invocations decoded and printed the full WAL range even though
the test only needs to confirm that a command form works or that
decoding reaches a specific error. Limit those checks to one record,
and start the fall-off-the-end checks near the end of the generated WAL.

This change reduces the IPC overhead overall, particularly on Windows,
without reducing coverage.

I am usually hesitant to backpatch such changes as this is only an
improvement, but the gains are too good in terms of IO and runtime, for
both the CI and the buildfarm.  Based on the numbers provided, the CI
takes 30% less time to run the test with this change on Windows (worst
case shown on the lists).  These tests have been introduced in
96063e28366b.

Author: Sehrope Sarkuni <sehrope@jackdb.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://postgr.es/m/CAH7T-araSEdsNpxiKaMOW8kr_ZHhekCLHx5yzm2ksq4FdgULbA@mail.gmail.com
Backpatch-through: 17

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8e6860fb9638b5db784a24419d4441f0bf2cd04c

Modified Files
--------------
src/bin/pg_waldump/t/001_basic.pl | 21 +++++++++++++++++----
1 file changed, 17 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: pg_dump: Fix performance regression in attribute statistics quer
Next
From: Richard Guo
Date:
Subject: pgsql: Remove quals made redundant by reducing outer joins to antijoins