pgsql: pg_dump: Fix performance regression in attribute statistics quer - Mailing list pgsql-committers

From Nathan Bossart
Subject pgsql: pg_dump: Fix performance regression in attribute statistics quer
Date
Msg-id E1x1W1h-000000035YR-3KDG@gemulon.postgresql.org
Whole thread
List pgsql-committers
pg_dump: Fix performance regression in attribute statistics query.

After adding pg_stats.tableid, we taught pg_dump to use it in the
attribute statistics query for servers running v19 or later.
Notably, we did not give this new form of the query a "redundant
filter clause" like we did the pre-v19 form.  Testing indicates
that produces a significant performance regression, and that adding
a similar filter clause to the v19-or-later form of the query fixes
it.

Oversight in commit 4b5ba0c4ca.

Reviewed-by: Sami Imseih <samimseih@gmail.com>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/apQ9nvLW_zFdarYd%40nathan
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/7da24355a2993721bf9bc54224b3bb3e601530ce

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Nathan Bossart
Date:
Subject: pgsql: Fix scaling of autovacuum freeze scores.
Next
From: Michael Paquier
Date:
Subject: pgsql: Speed up pg_waldump TAP test