pgsql: Further improve commentary about ChangeVarNodesWalkExpression() - Mailing list pgsql-committers

From Alexander Korotkov
Subject pgsql: Further improve commentary about ChangeVarNodesWalkExpression()
Date
Msg-id E1w4wav-001Css-1R@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Further improve commentary about ChangeVarNodesWalkExpression()

The updated comment explains why we use ChangeVarNodes_walker() instead of
expression_tree_walker(), and provides a bit more detail about the differences
in processing top-level Query and subqueries.

Author: Alexander Korotkov <aekorotkov@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/CAPpHfdvbjq342WTQ705Wmqhe8794pcp7wospz%2BWUJ2qB7vuOqA%40mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6888658516a20a2605087f557d96f3d0d0937608

Modified Files
--------------
src/backend/rewrite/rewriteManip.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Add support for lock statistics in pgstats
Next
From: Alexander Korotkov
Date:
Subject: pgsql: Further improve commentary about ChangeVarNodesWalkExpression()