Add support for lock statistics in pgstats
This commit adds a new stats kind, called PGSTAT_KIND_LOCK, implementing
statistics for lock tags, as reported by pg_locks. The implementation
is fixed-sized, as the data is caped based on the number of lock tags in
LockTagType.
The new statistics kind records the following fields, providing insight
regarding lock behavior, while avoiding impact on performance-critical
code paths (such as fast-path lock acquisition):
- waits and wait_time: respectively track the number of times a lock
required waiting and the total time spent acquiring it. These metrics
are only collected once a lock is successfully acquired and after
deadlock_timeout has been exceeded.
fastpath_exceeded: counts how often a lock could not be acquired via
the fast path due to the max_locks_per_transaction slot limits.
A new view called pg_stat_lock can be used to access this data, coupled
with a SQL function called pg_stat_get_lock().
Bump stat file format PGSTAT_FILE_FORMAT_ID.
Bump catalog version.
Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/aIyNxBWFCybgBZBS%40ip-10-97-1-34.eu-west-3.compute.internal
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4019f725f5d43f37b23222d06d20e3da1038d373
Modified Files
--------------
doc/src/sgml/monitoring.sgml | 110 ++++++++++++++++
src/backend/catalog/system_views.sql | 9 ++
src/backend/storage/lmgr/lock.c | 9 ++
src/backend/storage/lmgr/proc.c | 9 +-
src/backend/utils/activity/Makefile | 1 +
src/backend/utils/activity/meson.build | 1 +
src/backend/utils/activity/pgstat.c | 18 +++
src/backend/utils/activity/pgstat_lock.c | 178 ++++++++++++++++++++++++++
src/backend/utils/adt/pgstatfuncs.c | 39 ++++++
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 8 ++
src/include/pgstat.h | 30 ++++-
src/include/utils/pgstat_internal.h | 21 +++
src/include/utils/pgstat_kind.h | 5 +-
src/test/isolation/expected/lock-stats.out | 197 +++++++++++++++++++++++++++++
src/test/isolation/isolation_schedule | 1 +
src/test/isolation/specs/lock-stats.spec | 128 +++++++++++++++++++
src/test/regress/expected/rules.out | 6 +
src/test/regress/expected/stats.out | 48 +++++++
src/test/regress/sql/stats.sql | 36 ++++++
src/tools/pgindent/typedefs.list | 4 +
21 files changed, 854 insertions(+), 6 deletions(-)
