pgsql: Make pg_dump acquire lock on partitioned tables that are to be d - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make pg_dump acquire lock on partitioned tables that are to be d
Date
Msg-id E1mbmUt-0002i2-Jr@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make pg_dump acquire lock on partitioned tables that are to be dumped.

It was clearly the intent to do so all along, but the original coding
fat-fingered this by checking the wrong array element.  We fixed it
in passing in 403a3d91c, but that later got reverted, and we forgot
to keep this bug fix.

Most of the time this'd be relatively harmless, since once we lock
any of the partitioned table's leaf partitions, that would suffice
to prevent major DDL on the partitioned table itself.  However, a
childless partitioned table would get dumped with no relevant lock
whatsoever, possibly allowing dump failure or inconsistent output.

Unlike 403a3d91c, there are no versioning concerns, since every server
version that has partitioned tables will allow you to lock one.

Back-patch to v10 where partitioned tables were introduced.

Discussion: https://postgr.es/m/1018205.1634346327@sss.pgh.pa.us

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fd182a92ad90e2328c8e1fb601ca41f89a6a5585

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Add more $Test::Builder::Level in the TAP tests
Next
From: Tom Lane
Date:
Subject: pgsql: Avoid core dump in pg_dump when dumping from pre-8.3 server.