pgsql: Remove surplus call to table_finish_bulk_insert - Mailing list pgsql-committers

From David Rowley
Subject pgsql: Remove surplus call to table_finish_bulk_insert
Date
Msg-id E1hhy3g-0002Ds-Nl@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Remove surplus call to table_finish_bulk_insert  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Remove surplus call to table_finish_bulk_insert

4de60244e added the call to table_finish_bulk_insert to the
CopyMultiInsertBufferCleanup function.  We use a CopyMultiInsertBuffer even
for non-partitioned tables, so having the cleanup do that meant we would
call table_finsh_bulk_insert twice when performing COPY FROM with
a non-partitioned table.

Here we can just remove the direct call in CopyFrom and let
CopyMultiInsertBufferCleanup handle the call instead.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b2d69806d8cc902802a7b56ba37fb7c55e58b0ed

Modified Files
--------------
src/backend/commands/copy.c | 2 --
1 file changed, 2 deletions(-)


pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: Re: pgsql: Fix missing call to table_finish_bulk_insert during COPY
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Remove surplus call to table_finish_bulk_insert