pgsql: Disallow NaN as a value for floating-point GUCs. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Disallow NaN as a value for floating-point GUCs.
Date
Msg-id E1h31nX-0006xB-Sk@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disallow NaN as a value for floating-point GUCs.

None of the code that uses GUC values is really prepared for them to
hold NaN, but parse_real() didn't have any defense against accepting
such a value.  Treat it the same as a syntax error.

I haven't attempted to analyze the exact consequences of setting any
of the float GUCs to NaN, but since they're quite unlikely to be good,
this seems like a back-patchable bug fix.

Note: we don't need an explicit test for +-Infinity because those will
be rejected by existing range checks.  I added a regression test for
that in HEAD, but not older branches because the spelling of the value
in the error message will be platform-dependent in branches where we
don't always use port/snprintf.c.

Discussion: https://postgr.es/m/1798.1552165479@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f9ec64df8f25ecf69f870682abc6ff0950641610

Modified Files
--------------
src/backend/utils/misc/guc.c      | 4 ++++
src/test/regress/expected/guc.out | 5 +++++
src/test/regress/sql/guc.sql      | 4 ++++
3 files changed, 13 insertions(+)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: pg_upgrade: Ignore TOAST for partitioned tables
Next
From: Tom Lane
Date:
Subject: pgsql: Include GUC's unit, if it has one,in out-of-range error message