pgsql: Add missing and dangling downlink checks to amcheck - Mailing list pgsql-committers

From Teodor Sigaev
Subject pgsql: Add missing and dangling downlink checks to amcheck
Date
Msg-id E1fBLxd-0002AN-IG@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Add missing and dangling downlink checks to amcheck

When bt_index_parent_check() is called with the heapallindexed option,
allocate a second Bloom filter to fingerprint block numbers that appear
in the downlinks of internal pages.  Use Bloom filter probes when
walking the B-Tree to detect missing downlinks.  This can detect subtle
problems with page deletion/VACUUM, such as corruption caused by the bug
just fixed in commit 6db4b499.

The downlink Bloom filter is bound in size by work_mem.  Its optimal
size is typically far smaller than that of the regular heapallindexed
Bloom filter, especially when the index has high fan-out.

Author: Peter Geoghegan
Reviewer: Teodor Sigaev
Discussion: https://postgr.es/m/CAH2-WznUzY4fWTjm1tBB3JpVz8cCfz7k_qVp5BhuPyhivmWJFg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4eaf7eaccb291f5d32d9f05284bfca9c5744de9a

Modified Files
--------------
contrib/amcheck/verify_nbtree.c | 397 ++++++++++++++++++++++++++++++++++++++--
doc/src/sgml/amcheck.sgml       |   7 +-
2 files changed, 385 insertions(+), 19 deletions(-)


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: pgsql: Fix typo
Next
From: Tom Lane
Date:
Subject: pgsql: Change pgindent/README to specify that we use perltidy version2