[COMMITTERS] pgsql: Fix intra-query memory leakage in nodeProjectSet.c. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix intra-query memory leakage in nodeProjectSet.c.
Date
Msg-id E1e0XMd-0002Gq-IV@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix intra-query memory leakage in nodeProjectSet.c.

Both ExecMakeFunctionResultSet() and evaluation of simple expressions
need to be done in the per-tuple memory context, not per-query, else
we leak data until end of query.  This is a consideration that was
missed while refactoring code in the ProjectSet patch (note that in
pre-v10, ExecMakeFunctionResult is called in the per-tuple context).

Per bug #14843 from Ben M.  Diagnosed independently by Andres and myself.

Discussion: https://postgr.es/m/20171005230321.28561.15927@wrigleys.postgresql.org

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0c25e9652461c08b5caef259a6af27a38707e07a

Modified Files
--------------
src/backend/executor/execSRF.c        | 2 ++
src/backend/executor/nodeProjectSet.c | 6 ++++++
2 files changed, 8 insertions(+)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [COMMITTERS] pgsql: Basic partition-wise join functionality.
Next
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Copy information from the relcache instead of pointing to it.