[COMMITTERS] pgsql: Fix reversed check of return value from sync - Mailing list pgsql-committers

From Magnus Hagander
Subject [COMMITTERS] pgsql: Fix reversed check of return value from sync
Date
Msg-id E1cyGpJ-00037c-3Q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix reversed check of return value from sync

While at it also update the comments in walmethods.h to make it less
likely for mistakes like this to appear in the future (thanks to Tom for
improvements to the comments).

And finally, in passing change the return type of walmethod.getlasterror
to being const, also per suggestion from Tom.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b935eb7da37254a18c48acc7b07517c8dfbb2339

Modified Files
--------------
src/bin/pg_basebackup/receivelog.c |  5 ++++-
src/bin/pg_basebackup/walmethods.c |  4 ++--
src/bin/pg_basebackup/walmethods.h | 46 +++++++++++++++++++++++++++++++++++++-
3 files changed, 51 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [COMMITTERS] pgsql: Remove bogus redefinition of _MSC_VER.
Next
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Code review for c94e6942cefe7d20c5feed856e27f672734b1e2b.