Re: [COMMITTERS] pgsql: Remove bogus redefinition of _MSC_VER. - Mailing list pgsql-committers

From Magnus Hagander
Subject Re: [COMMITTERS] pgsql: Remove bogus redefinition of _MSC_VER.
Date
Msg-id CABUevEwME40nigN=oVs_4FHtDurxfvcQatXtt1r1bxKkx67UWg@mail.gmail.com
Whole thread Raw
In response to [COMMITTERS] pgsql: Remove bogus redefinition of _MSC_VER.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Thanks!

The sad thing is that I did that file manually first, the right way. Then I realized I was going down the wrong track and made the change mechanical instead. And forgot to change that one back..

Oops.

//Magnus


On Tue, Apr 11, 2017 at 9:32 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Remove bogus redefinition of _MSC_VER.

Commit a4777f355 was a shade too mechanical: we don't want to override
MSVC's own definition of _MSC_VER, as that breaks tests on its numerical
value.  Per buildfarm.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/587d62d8562d658a2a9be60bc4574b6f9e592cb1

Modified Files
--------------
src/tools/msvc/ecpg_regression.proj | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



--

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Remove bogus redefinition of _MSC_VER.
Next
From: Magnus Hagander
Date:
Subject: [COMMITTERS] pgsql: Fix reversed check of return value from sync