pgAdmin 4 commit: Improvised Select2Cell, and SwitchCell. - Mailing list pgadmin-hackers

From Ashesh Vashi
Subject pgAdmin 4 commit: Improvised Select2Cell, and SwitchCell.
Date
Msg-id E1apwQd-000280-1u@gothos.postgresql.org
Whole thread Raw
List pgadmin-hackers
Improvised Select2Cell, and SwitchCell.

Removed the use of separate editor for both of these cell types. There
were two instance of select2 were getting created in the Select2Cell,
one in the Select2Cell itself, and another in Select2CellEditor. And,
loosing the focus mysteriously, and making the scrollbar in the property
dialog non-responsive.

Also, modified the NodeAjaxOptionsCell to use the above logic, and
removed its own version of render function to make it consitent across
the system.

This patch [changes sent by Murtuza] also includes improvisation in the
DeleteCell, and ObjectCell, which will honour now 'canRemoveRow', and
''canEditRow' respective properties of Column.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9b9126da15f0284e64d7f051f01fc54a403eb332

Modified Files
--------------
web/pgadmin/browser/static/js/node.ui.js           |  85 +-----
web/pgadmin/static/js/backgrid/backgrid.pgadmin.js | 302 ++++++++++-----------
2 files changed, 153 insertions(+), 234 deletions(-)


pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: [pgAdmin4][Patch] Add affected row count support in psycopg2
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Remove unnecessary line of code.