pgsql: Fix json_to_record() bug with nested objects. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix json_to_record() bug with nested objects.
Date
Msg-id E1abKvf-0007oW-Jd@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix json_to_record() bug with nested objects.

A thinko concerning nesting depth caused json_to_record() to produce bogus
output if a field of its input object contained a sub-object with a field
name matching one of the requested output column names.  Per bug #13996
from Johann Visagie.

I added a regression test case based on his example, plus parallel tests
for json_to_recordset, jsonb_to_record, jsonb_to_recordset.  The latter
three do not exhibit the same bug (which suggests that we may be missing
some opportunities to share code...) but testing seems like a good idea
in any case.

Back-patch to 9.4 where these functions were introduced.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/597e41e45eec8038b8c2c1153d1d050bfafeacbf

Modified Files
--------------
src/backend/utils/adt/jsonfuncs.c   |  2 +-
src/test/regress/expected/json.out  | 16 ++++++++++++++++
src/test/regress/expected/jsonb.out | 16 ++++++++++++++++
src/test/regress/sql/json.sql       |  9 ++++++++-
src/test/regress/sql/jsonb.sql      |  8 ++++++++
5 files changed, 49 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix json_to_record() bug with nested objects.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix json_to_record() bug with nested objects.