pgsql: initdb -S should now have an explicit check that $PGDATA is vali - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: initdb -S should now have an explicit check that $PGDATA is vali
Date
Msg-id E1YyRQm-0006FJ-QI@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
initdb -S should now have an explicit check that $PGDATA is valid.

The fsync code from the backend essentially assumes that somebody's already
validated PGDATA, at least to the extent of it being a readable directory.
That's safe enough for initdb's normal code path too, but "initdb -S"
doesn't have any other processing at all that touches the target directory.
To have reasonable error-case behavior, add a pg_check_dir call.
Per gripe from Peter E.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/c2b68b1f7d6de9e749d037a09c5875742e8e6250

Modified Files
--------------
src/bin/initdb/initdb.c |   11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
Next
From: Tom Lane
Date:
Subject: pgsql: initdb -S should now have an explicit check that $PGDATA is vali