Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
Date
Msg-id 27843.1432929966@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-committers
Peter Eisentraut <peter_e@gmx.net> writes:
> On 5/29/15 1:05 PM, Tom Lane wrote:
>> Adjust initdb to also not consider fsync'ing failures fatal.

> This introduces a failure in the initdb tests, which expect that
>     initdb -S -D /notthere
> returns a nonzero exit code.

Hm, I guess we don't run anything else that touches the DB directory
in this case?  In the backend case we'd have failed much earlier.

I'm not 100% convinced that the test case's expectation is necessarily
the right thing, though.

            regards, tom lane


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.
Next
From: Tom Lane
Date:
Subject: pgsql: initdb -S should now have an explicit check that $PGDATA is vali