pgsql: Remove special cases for ETXTBSY from new fsync'ing logic. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.
Date
Msg-id E1YyPhG-0004Ub-33@gemulon.postgresql.org
Whole thread Raw
Responses Re: pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Remove special cases for ETXTBSY from new fsync'ing logic.

The argument that this is a sufficiently-expected case to be silently
ignored seems pretty thin.  Andres had brought it up back when we were
still considering that most fsync failures should be hard errors, and it
probably would be legit not to fail hard for ETXTBSY --- but the same is
true for EROFS and other cases, which is why we gave up on hard failures.
ETXTBSY is surely not a normal case, so logging the failure seems fine
from here.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/77642a8197ed7fa3a5113bdca914e4685e957455

Modified Files
--------------
src/backend/storage/file/fd.c |   15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Check that all aliases of a built-in function have same leakproo
Next
From: Tom Lane
Date:
Subject: pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.