Re: pgsql: Remove special cases for ETXTBSY from new fsync'ing logic. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.
Date
Msg-id 20150529214927.GA6535@alap3.anarazel.de
Whole thread Raw
In response to pgsql: Remove special cases for ETXTBSY from new fsync'ing logic.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On 2015-05-29 19:11:58 +0000, Tom Lane wrote:
> Andres had brought it up back when we were
> still considering that most fsync failures should be hard errors, and it
> probably would be legit not to fail hard for ETXTBSY --- but the same is
> true for EROFS and other cases, which is why we gave up on hard failures.
> ETXTBSY is surely not a normal case, so logging the failure seems fine
> from here.

Note that EROFS etc should never happen without following symlinks,
whereas ETXTBSY conceivably could.


I'm fine though, with the special case being removed, I think you made a
good point that it's unlikely that e.g. an archive_command will run
during startup.


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: pg_upgrade: add missing period in C comment
Next
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Adjust initdb to also not consider fsync'ing failures fatal.