Re: pgsql: Clean up role created in new subscription test. - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pgsql: Clean up role created in new subscription test.
Date
Msg-id E0EB10CE-9B58-44C0-8CBC-807BC8E5A84A@yesql.se
Whole thread Raw
In response to Re: pgsql: Clean up role created in new subscription test.  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: pgsql: Clean up role created in new subscription test.
Re: pgsql: Clean up role created in new subscription test.
List pgsql-hackers
> On 8 Nov 2023, at 13:32, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:

> I suppose you're just thinking of using PQexec() or whatever, run one
> query with sufficient ORDER BY, save the result, and at the end of the
> test run just run the same query and compare that they are cell-by-cell
> identical?  This sounds a lot simpler than the patch you posted.

I found some spare cycles for this and came up with the attached.  The idea was
to keep it in-line with how pg_regress already today manipulate and traverse
_stringlists for various things.  With the addition of the 0001 patch to clean
up global objects left in test_pg_dump it passes check-world.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: Fix a wrong comment in setrefs.c
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Clean up role created in new subscription test.