Re: pgsql: Clean up role created in new subscription test. - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pgsql: Clean up role created in new subscription test.
Date
Msg-id 202311081232.rn3aho5ay6yx@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Clean up role created in new subscription test.  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: pgsql: Clean up role created in new subscription test.
Re: pgsql: Clean up role created in new subscription test.
List pgsql-hackers
On 2023-Nov-08, Daniel Gustafsson wrote:

> Since test_setup.sql is part of the regress schedule and not pg_regress we
> would have to implement this for each test run (regress, contribs etc), which
> is what Peter didn't like about the original suggestion.

Oh, somehow that aspect of his reply failed to register with me.  I
agree with your approach of using libpq in pg_regress then.

I suppose you're just thinking of using PQexec() or whatever, run one
query with sufficient ORDER BY, save the result, and at the end of the
test run just run the same query and compare that they are cell-by-cell
identical?  This sounds a lot simpler than the patch you posted.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pgsql: Clean up role created in new subscription test.
Next
From: "Zakhlystov, Daniil (Nebius)"
Date:
Subject: Re: Force the old transactions logs cleanup even if checkpoint is skipped