Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
Date
Msg-id E06CED92-C740-4264-99E2-EE4DB2453BCF@yesql.se
Whole thread Raw
In response to Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
List pgsql-hackers
> On 19 Nov 2025, at 14:01, Fujii Masao <masao.fujii@gmail.com> wrote:

> You changed the HINT message to use format arguments,
> but I still think it's better to embed the values directly (e.g.,
> Valid encodings are "base64", "base64url", "escape", and "hex".)
> for consistency with similar HINT messages. If this message is
> used in many places a parameterized style would help translators,
> but that benefit doesn't apply here.
> 
> Attached is an updated version of the patch. I switched
> the HINT message to the embedded form and updated the commit message.
> Barring any objections, I'm thinking to commit this.

My intepreration was that this version was already objected to by Peter
upthread in c5c937dc-de8e-4284-be25-5d5eaf089d00@eisentraut.org.  The point
there being that punctuation in lists is subject to translation.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions
Next
From: Xuneng Zhou
Date:
Subject: Re: Improve read_local_xlog_page_guts by replacing polling with latch-based waiting