Re: [PATCH] Add hints for invalid binary encoding names in encode/decode functions - Mailing list pgsql-hackers

On Wed, Nov 19, 2025 at 10:04 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 19 Nov 2025, at 14:01, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> > You changed the HINT message to use format arguments,
> > but I still think it's better to embed the values directly (e.g.,
> > Valid encodings are "base64", "base64url", "escape", and "hex".)
> > for consistency with similar HINT messages. If this message is
> > used in many places a parameterized style would help translators,
> > but that benefit doesn't apply here.
> >
> > Attached is an updated version of the patch. I switched
> > the HINT message to the embedded form and updated the commit message.
> > Barring any objections, I'm thinking to commit this.
>
> My intepreration was that this version was already objected to by Peter
> upthread in c5c937dc-de8e-4284-be25-5d5eaf089d00@eisentraut.org.  The point
> there being that punctuation in lists is subject to translation.

Yes, so I was thinking a message like "Valid encodings are %s" isn't acceptable
since the punctuation included in the %s value is not translated. In contrast,
a message like "Valid encodings are \"base64\", …" is fine because all
punctuation
is part of the translatable string itself, I thought.

But maybe I'm missing something?

Regards,

--
Fujii Masao