On Mon Nov 10, 2025 at 11:06 PM -03, Rohit Prasad wrote:
> Hi Michael,
>
I think you wanted to say Matheus :)
> I am just getting started in the Postgres community (this is my first
> code review). So please excuse me if I have missed something (in terms
> of process etc).
>
Thank you for reviewing this!
> I reviewed your proposed code changes in the attached patch file and
> they look good to me.
>
Thanks.
> I have some minor comments:
> 1. In src/test/modules/test_extensions/t/001_extension_control_path.pl,
> it would be nice if you could add a test that validates that the
> correct Extension location is displayed, if for example, the extension
> is being picked up from a customized location.
>
I don't know if I get your point here. On the v4 patch we have:
- "test_custom_ext_paths|1.0|1.0|Test extension_control_path",
+ "test_custom_ext_paths|1.0|1.0|Test extension_control_path|$ext_dir_canonicalized/extension",
The $ext_dir_canonicalized in this case is a custom path configured on
extension_control_path GUC that the "test_custom_ext_paths" extension
was installed.
> 2. Nit-pick: In
> src/backend/commands/extension.c:get_available_versions_for_extension(),
> you could probably combine the following 2 lines into one to say
> "'comment' & 'location' stay the same.
> /* comment stays the same */
> /* location stays the same */
>
Fixed on attached v5
On this new v5 version I also swap the order of "comment" and "location"
columns as it was suggested by Michael.
--
Matheus Alcantara
EDB: http://www.enterprisedb.com
