Re: Include extension path on pg_available_extensions - Mailing list pgsql-hackers

From Rohit Prasad
Subject Re: Include extension path on pg_available_extensions
Date
Msg-id 176282677490.2081919.14769189141245328542.pgcf@coridan.postgresql.org
Whole thread Raw
In response to Re: Include extension path on pg_available_extensions  (Michael Banck <mbanck@gmx.net>)
Responses Re: Include extension path on pg_available_extensions
List pgsql-hackers
Hi Michael,

I am just getting started in the Postgres community (this is my first code review). So please excuse me if I have
missedsomething (in terms of process etc).
 
I reviewed your proposed code changes in the attached patch file and they look good to me. I have some minor comments:

1. In src/test/modules/test_extensions/t/001_extension_control_path.pl, it would be nice if you could add a test that
validatesthat the correct Extension location is displayed, if for example, the extension is being picked up from a
customizedlocation. 
 
2. Nit-pick: In src/backend/commands/extension.c:get_available_versions_for_extension(), you could probably combine the
following2 lines into one to say "'comment' & 'location' stay the same.
 
                    /* comment stays the same */                                                          
                   /* location stays the same */
                                                                                         
 

Hope this is helpful.

Thanks,
-Rohit

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH] libpq: Wrap out-of-memory error messages with libpq_gettext()
Next
From: Chao Li
Date:
Subject: Re: Suggestion to add --continue-client-on-abort option to pgbench