Re: Improve const use in zlib-using code - Mailing list pgsql-hackers

From Tristan Partin
Subject Re: Improve const use in zlib-using code
Date
Msg-id CUI4WVZG4O7S.3J2ETML5DM6WO@gonk
Whole thread Raw
In response to Improve const use in zlib-using code  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Improve const use in zlib-using code
List pgsql-hackers
Peter,

I like the idea. Though the way you have it implemented at the moment
seems like a trap in that any time zlib.h is included someone also has
to remember to add this define. I would recommend adding the define to
the build systems instead.

Since you put in the work to find the version of zlib that added this,
You might also want to add `required: '>= 1.2.5.2'` to the
`dependency('zlib')` call in the main meson.build. I am wondering if we
could remove the `z_streamp` check too. The version that it was added
isn't obvious.

--
Tristan Partin
Neon (https://neon.tech)



pgsql-hackers by date:

Previous
From: "Rui Zhao"
Date:
Subject: Re: pg_upgrade fails with in-place tablespace
Next
From: Sergey Dudoladov
Date:
Subject: Re: PATCH: Using BRIN indexes for sorted output