Re: Clean up some signal usage mainly related to Windows - Mailing list pgsql-hackers

On Wed Jul 12, 2023 at 3:56 AM CDT, Peter Eisentraut wrote:
> On 06.07.23 22:43, Tristan Partin wrote:
> >       /* Finish incomplete line on stdout */
> > -    puts("");
> > -    exit(1);
> > +    write(STDOUT_FILENO, "", 1);
> > +    _exit(1);
>
> puts() writes a newline, so it should probably be something like
>
>      write(STDOUT_FILENO, "\n", 1);

Silly mistake. Thanks. v2 attached.

It has come to my attention that STDOUT_FILENO might not be portable and
fileno(3) isn't marked as signal-safe, so I have just used the raw 1 for
stdout, which as far as I know is portable.

--
Tristan Partin
Neon (https://neon.tech)