Re: Why we don't have checksums on clog files - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Why we don't have checksums on clog files
Date
Msg-id CAPpHfdvhyzN=uBfaBubaUiAqnTFDoUgsrSReCdD7Ovrq_oMPtA@mail.gmail.com
Whole thread Raw
In response to Re: Why we don't have checksums on clog files  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, Jun 7, 2016 at 5:41 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
On Mon, Jun 6, 2016 at 8:43 PM, Alex Ignatov <a.ignatov@postgrespro.ru> wrote:
Why we don't have checksums on clog files.

We have checksum on pg_control, optional checksumming on data files, some form of checksumming on wal's. But why we don't have any checksumming on clogs. Corruptions on clogs lead to transaction visisbility problems and database consistency violation.

Can anybody explain this situation with clogs?


I think it will be better if users can have an option to checksum clog pages.  However, I think that will need a change in page (CLOG-page) format which might not be a trivial work to accomplish.

I think we should think no only about CLOG, but about all SLRU pages.
For data pages we have to reinitialize database cluster to enable checksums. I think we can also require reinitialization to enable checksums of SLRU pages. Thus, major problem would be that number of items fitting to page would depend on whether checksums are enabled.  However, it shouldn't too hard.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Why we don't have checksums on clog files
Next
From: Robert Haas
Date:
Subject: Re: Re: pg9.6 segfault using simple query (related to use fk for join estimates)