Re: GIN improvements part 1: additional information - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: GIN improvements part 1: additional information
Date
Msg-id CAPpHfdvEWwDoVirLtbOTjLkBXsCgmp49K9TAWJCu+ato47uuzQ@mail.gmail.com
Whole thread Raw
In response to Re: GIN improvements part 1: additional information  (Antonin Houska <antonin.houska@gmail.com>)
List pgsql-hackers
On Thu, Jun 27, 2013 at 6:20 PM, Antonin Houska <antonin.houska@gmail.com> wrote:
On 06/25/2013 12:03 AM, Alexander Korotkov wrote:


New revision of patch is attached. Now it includes some docs.



Hi,
I was curious about the new layout of the data page, so I spent a while looking into the code.
It's interesting, but I suspect 2 things are not o.k.:

* gindatapage.c:dataIsEnoughSpace() - 'i++' in the for loop should probably be 'j++', otherwise it loops forever

* gin_private.h:ginDataPageLeafRead() - fetch_att() is used to retrieve the additional info, but per the definition and comments in tupmacs.h it expects aligned pointer.

* gindatapage.c:ginCheckPlaceToDataPageLeaf() -  comment "if leaf data page" should probably be "on a leaf data page" or so.

Hi!

Thanks for pointing these.

------
With best regards,
Alexander Korotkov.

pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: GIN improvements part 1: additional information
Next
From: Fabien COELHO
Date:
Subject: Re: [PATCH] add --progress option to pgbench (submission 3)