Re: GIN improvements part 1: additional information - Mailing list pgsql-hackers

From Antonin Houska
Subject Re: GIN improvements part 1: additional information
Date
Msg-id 51CC4A44.2080905@gmail.com
Whole thread Raw
In response to Re: GIN improvements part 1: additional information  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: GIN improvements part 1: additional information  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Re: GIN improvements part 1: additional information  (Alexander Korotkov <aekorotkov@gmail.com>)
List pgsql-hackers
On 06/25/2013 12:03 AM, Alexander Korotkov wrote:
>
>
> New revision of patch is attached. Now it includes some docs.
>
>

Hi,
I was curious about the new layout of the data page, so I spent a while 
looking into the code.
It's interesting, but I suspect 2 things are not o.k.:

* gindatapage.c:dataIsEnoughSpace() - 'i++' in the for loop should 
probably be 'j++', otherwise it loops forever

* gin_private.h:ginDataPageLeafRead() - fetch_att() is used to retrieve 
the additional info, but per the definition and comments in tupmacs.h it 
expects aligned pointer.

* gindatapage.c:ginCheckPlaceToDataPageLeaf() -  comment "if leaf data 
page" should probably be "on a leaf data page" or so.

Regards,
Antonin Houska (Tony)



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Add more regression tests for dbcommands
Next
From: Fujii Masao
Date:
Subject: Re: [PATCH] add long options to pgbench (submission 1)