Postgres Pro
Downloads
Home   >   mailing lists

Re: Corrupted btree index on HEAD because of covering indexes - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Corrupted btree index on HEAD because of covering indexes
Date
Msg-id CAPpHfduuGu32JtLNAcSg_v8coaLbYd5VNhe_GFG_ibu7Rtiq+g@mail.gmail.com
Whole thread Raw
In response to Re: Corrupted btree index on HEAD because of covering indexes  (Teodor Sigaev <teodor@sigaev.ru>)
Responses Re: Corrupted btree index on HEAD because of covering indexes  (Peter Geoghegan <pg@bowt.ie>)
Re: Corrupted btree index on HEAD because of covering indexes  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Tree view
On Thu, Apr 19, 2018 at 10:47 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:
I also think that we could have better conventional regression test
coverage here.

 I tried to minimize Michael's test case and add it to patch.

- if (ItemPointerIsValid(leafhikey))
+ if (ItemPointerGetBlockNumberNoCheck(leafhikey) != InvalidBlockNumber)

Should we use BTreeInnerTupleGetDownLink() as soon as we use
BTreeInnerTupleSetDownLink() for setting this?
Or even invent BTreeInnerTupleDownLinkIsValid() macro?
 
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Built-in connection pooling
Next
From: Tom Lane
Date:
Subject: Re: Documentation for bootstrap data conversion