Re: Bug in GiST paring heap comparator - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Bug in GiST paring heap comparator
Date
Msg-id CAPpHfdskuYR5tN78u7Yk_H9SQdnjnYFZZ8aQ69jRbXrRVzV=9g@mail.gmail.com
Whole thread Raw
In response to Re: Bug in GiST paring heap comparator  (Nikita Glukhov <n.gluhov@postgrespro.ru>)
Responses Re: Bug in GiST paring heap comparator
List pgsql-hackers
On Mon, Sep 9, 2019 at 8:32 PM Nikita Glukhov <n.gluhov@postgrespro.ru> wrote:
> On 08.09.2019 22:32, Alexander Korotkov wrote:
>
> > On Fri, Sep 6, 2019 at 5:44 PM Alexander Korotkov
> > <a.korotkov@postgrespro.ru> wrote:
> >> I'm going to push both if no objections.
> > So, pushed!
>
> Two years ago there was a similar patch for this issue:
> https://www.postgresql.org/message-id/1499c9d0-075a-3014-d2aa-ba59121b3728%40postgrespro.ru
>
> Sorry that I looked at this thread too late.

I see, thanks.

You patch seems a bit less cumbersome thanks to using GISTDistance
struct.  You don't have to introduce separate array with null flags.
But it's harder too keep index_store_float8_orderby_distances() used
by both GiST and SP-GiST.

What do you think?  You can rebase your patch can propose that as refactoring.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



pgsql-hackers by date:

Previous
From: Yuli Khodorkovskiy
Date:
Subject: Re: add a MAC check for TRUNCATE
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] [WIP] Effective storage of duplicates in B-tree index.