Re: use of SPI by postgresImportForeignStatistics - Mailing list pgsql-hackers

Fujii-san,

On Fri, Jul 10, 2026 at 2:37 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> In the committed patch, I found that the set_*_arg() helper functions
> in postgres_fdw.c are declared static in their prototypes, but their
> definitions omit the static keyword. This looks like an oversight.
>
> Attached patch adds static to the definitions for consistency and
> to make their intended file-local scope explicit. It also fixes a few
> nearby comment typos.

Good catch!  Thanks for the patch!  LGTM.

Best regards,
Etsuro Fujita