Re: use of SPI by postgresImportForeignStatistics - Mailing list pgsql-hackers

On Fri, Jul 10, 2026 at 2:03 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
>
> On Wed, Jul 8, 2026 at 9:04 PM Etsuro Fujita <etsuro.fujita@gmail.com> wrote:
> > Attached is a new version
> > of the patch.  I'm planning to push and back-patch it, if no
> > objections.
>
> Committed and back-patched.

In the committed patch, I found that the set_*_arg() helper functions
in postgres_fdw.c are declared static in their prototypes, but their
definitions omit the static keyword. This looks like an oversight.

Attached patch adds static to the definitions for consistency and
to make their intended file-local scope explicit. It also fixes a few
nearby comment typos.

Regards,

--
Fujii Masao