Comment in portal.h - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Comment in portal.h
Date
Msg-id CAPmGK14HVYBZYZtHabjeCd-e31VT=wx6rQNq8QfehywLcpZ2Hw@mail.gmail.com
Whole thread Raw
List pgsql-hackers
Hi,

I noticed $SUBJECT while working on something else:

    /*
     * Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING or
     * PORTAL_UTIL_SELECT query.  (A cursor held past the end of its
     * transaction no longer has any active executor state.)
     */
    Tuplestorestate *holdStore; /* store for holdable cursors */
    MemoryContext holdContext;  /* memory containing holdStore */

We do that for PORTAL_ONE_MOD_WITH as well, so the comment should be
"Where we store tuples for a held cursor or a PORTAL_ONE_RETURNING,
PORTAL_ONE_MOD_WITH, or PORTAL_UTIL_SELECT query.".  Attached is a
patch for that.

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: speed up a logical replica setup
Next
From: Amit Kapila
Date:
Subject: Re: Slow catchup of 2PC (twophase) transactions on replica in LR