Re: Bug: trailing comma syntax error in postgres_fdw fetch_attstats() - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Bug: trailing comma syntax error in postgres_fdw fetch_attstats()
Date
Msg-id CAPmGK14BrhJvBnxCsz-eBy0Qh6kUUYLL+N6U2W5mRNwpHmGjGQ@mail.gmail.com
Whole thread Raw
In response to Bug: trailing comma syntax error in postgres_fdw fetch_attstats()  (SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>)
List pgsql-hackers
On Sun, Apr 12, 2026 at 10:45 AM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
> When importing statistics from a remote server running PostgreSQL < 17,
> fetch_attstats() emits three NULL placeholders for the range statistics
> columns that don't exist on older servers.  The string literal included a trailing
> comma after the last NULL, producing invalid SQL:
>
>     SELECT ... NULL, NULL, NULL, FROM pg_catalog.pg_stats ...
>
> This fails ANALYZE or IMPORT STATISTICS on a foreign table backed
> by a pre-v17 remote server with a syntax error.

My bad, I will take care of this.  I added it to the open item.

Thanks for the report and patch!

Best regards,
Etsuro Fujita



pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Import Statistics in postgres_fdw before resorting to sampling.
Next
From: Etsuro Fujita
Date:
Subject: Re: Fix array-element quoting in postgres_fdw import statistics