Bug: trailing comma syntax error in postgres_fdw fetch_attstats() - Mailing list pgsql-hackers

From SATYANARAYANA NARLAPURAM
Subject Bug: trailing comma syntax error in postgres_fdw fetch_attstats()
Date
Msg-id CAHg+QDdEE7wp1S60Fn9Kmna8KfdMo5Tu6dROLpMn_-EOUBKmWQ@mail.gmail.com
Whole thread Raw
Responses Re: Bug: trailing comma syntax error in postgres_fdw fetch_attstats()
List pgsql-hackers
Hi Hackers,

When importing statistics from a remote server running PostgreSQL < 17,
fetch_attstats() emits three NULL placeholders for the range statistics
columns that don't exist on older servers.  The string literal included a trailing
comma after the last NULL, producing invalid SQL:

    SELECT ... NULL, NULL, NULL, FROM pg_catalog.pg_stats ...

This fails ANALYZE or IMPORT STATISTICS on a foreign table backed
by a pre-v17 remote server with a syntax error.

Thanks,
Satya
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: StringInfo fixes, v19 edition. Plus a few oddities
Next
From: SATYANARAYANA NARLAPURAM
Date:
Subject: Fix array-element quoting in postgres_fdw import statistics