Re: Move bki file pre-processing from initdb to bootstrap - Mailing list pgsql-hackers

From Krishnakumar R
Subject Re: Move bki file pre-processing from initdb to bootstrap
Date
Msg-id CAPMWgZ9CWwhe6M=0EDWjXaqf70TfRuW=EHyxvc9A4CRHZ36Cdg@mail.gmail.com
Whole thread Raw
In response to Re: Move bki file pre-processing from initdb to bootstrap  (Krishnakumar R <kksrcv001@gmail.com>)
Responses Re: Move bki file pre-processing from initdb to bootstrap
List pgsql-hackers
> The version comparison has been moved from initdb to bootstrap. This
> created some compatibility problems with windows tests. For now I kept
> the version check to not have \n added, which worked fine and serves
> the purpose. However hoping to have something better in v3 in addition
> to addressing any other comments.

With help from Thomas, figured out that on windows fopen uses binary
mode in the backend which causes issues with EOL. Please find the
attached patch updated with a fix for this.

--
Thanks and Regards,
Krishnakumar (KK).
[Microsoft]

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: run pgindent on a regular basis / scripted manner
Next
From: Peter Geoghegan
Date:
Subject: Re: run pgindent on a regular basis / scripted manner