Request a Demo
Home   >   mailing lists

Re: pgsql: Make cancel request keys longer - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: pgsql: Make cancel request keys longer
Date
Msg-id CAOYmi+nmqLB9jYPy0PNmTbLbzrAEfwrGVeKe4G_S4fRs4-D52w@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Make cancel request keys longer  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Tree view 
On Thu, May 8, 2025 at 11:38 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> It didn't occur to me that you could write it simply as 'msgLength - 4'.
> That depends on knowing that the preceding fields are exactly 4 bytes
> long, but that's clear enough if we just add a comment on that, see
> attached.

Sorry for the conference delay; this looks fine to me.

One of the side effects of the uint8 change is that the client now
accepts cancel keys up to roughly 30kb. Is that intended?

--Jacob

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: tighten generic_option_name, or store more carefully in catalog?
Next
From: Michael Paquier
Date:
Subject: Re: Retiring some encodings?