Re: restore_command return code behaviour - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: restore_command return code behaviour
Date
Msg-id CAOYmi+nYMJCbeQpTtE2BsdJr=28SLoOvKpk6uajYoHtSvnOD-g@mail.gmail.com
Whole thread Raw
In response to Re: restore_command return code behaviour  (Jean-Christophe Arnu <jcarnu@gmail.com>)
Responses Re: restore_command return code behaviour
List pgsql-hackers
On Mon, Jul 28, 2025 at 1:58 PM Jean-Christophe Arnu <jcarnu@gmail.com> wrote:
> Or
>
> The recovery will be aborted and the server will stop if any of the following events occur:
> - the command was terminated by a signal other than SIGTERM (which is used as part of a database server shutdown);
> - the command returns an exit code greater than 125
> - the shell returns an error (such as 'command not found')
>
> The former has a 'heavier' style; the latter has the benefit of clearly showing each condition for shutting down the
server(but it breaks the GUC style, where bullet points are only used for defining possible values). 

I like the latter. Riffing on that, we could collapse the bullet
points and reuse a bit of the current wording:

Recovery will abort and the server will not start up if any of the
following events occur: the command is terminated by a signal other
than SIGTERM (which is used as part of a database server shutdown);
the command returns an exit status greater than 125; or the shell
returns an error, such as "command not found".

WDYT?
--Jacob



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: refactor backend type lists
Next
From: Álvaro Herrera
Date:
Subject: Re: Making pgfdw_report_error statically analyzable