Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?) - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)
Date
Msg-id CAOYmi+nWwDQmXLDhH+vmpyp-Y-ELydxv6sg8Oy81qvYUFn+vxg@mail.gmail.com
Whole thread
In response to Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)  (Zsolt Parragi <zsolt.parragi@percona.com>)
Responses Re: [oauth] Stabilize the libpq-oauth ABI (and allow alternative implementations?)
List pgsql-hackers
On Tue, Mar 10, 2026 at 3:10 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
> +#define MASK_BITS ((uintptr_t) 0x55aa55aa55aa55aa)
>
>  Won't this cause a warning in 32 bit builds? (0x55aa55aa definitely
> should work in both?)

Hopefully not -- it's an explicit rather than implicit truncation, and
we've required 64-bit integer support from our compilers for a long
time now. But I'm bad at keeping the rules in my head; did you have a
particular compiler in mind?

(The 32-bit build in Cirrus doesn't seem to mind this, though it does
mind the unused variables that I forgot to wrap in USE_VALGRIND...
will fix.)

--Jacob



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Streamify more code paths
Next
From: Andres Freund
Date:
Subject: Re: Streamify more code paths