Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4] [Patch]: Language Module - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin4] [Patch]: Language Module
Date
Msg-id CANxoLDdz5piaZJdo0hODmY-2McH3JBnXMRp76iCo_nZuUpY27w@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4] [Patch]: Language Module  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgAdmin4] [Patch]: Language Module
List pgadmin-hackers
Tree view
Hi All

Attached is the new patch after fixing review comments given by Dave.

On Fri, Feb 12, 2016 at 10:04 PM, Dave Page <dpage@pgadmin.org> wrote:


On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

New language patch is working fine.
Ashesh - Can you please review it ?
If it looks good then can you please commit ?

Thank you,
Harshal

A few comments:

- We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't we also therefore omit DROP LANGUAGE?
    Fixed. 
- Please leave a blank line between the file header and python code in python files.
    Fixed. 
- The pydoc module description is missing from __init__.py
    Fixed. 
- What about the Dependents and Dependencies tabs?
     Infrastructure is not ready, so not implemented yet. 
 
- There are few, if any comments in the Javascript. There should be at least minimal comments there to note the purpose of each logical code block.
    Fixed. 


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Attachment

pgadmin-hackers by date:

Previous
From: Neel Patel
Date:
Subject: Re: [pgAdmin4] [Patch]: Resource Group Module
Next
From: Harshal Dhumal
Date:
Subject: work status