Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM5815] Generate script is not working in new window - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM5815] Generate script is not working in new window
Date
Msg-id CANxoLDdwhpo4J+m3-CaavhvaDi2rg9G-QPUk6ivQPeA-XTMN+Q@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM5815] Generate script is not working in new window  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Thanks, patch applied.

On Wed, Sep 9, 2020 at 3:19 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

If schema diff is opened in a new tab and "Generate script" is clicked (with query tool setting "open in new tab" set to true) then it shows a forever spinner because of pop up blocks.

Attached patch will show an alert message in that case so that the user can allow pop up and generate the script again.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed an issue where clicking on the 'Generate script
Next
From: Akshay Joshi
Date:
Subject: Re: [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window