[pgAdmin][RM5815] Generate script is not working in new window - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject [pgAdmin][RM5815] Generate script is not working in new window
Date
Msg-id CAM9w-_knay-688=uCiM7C=C+79H2-t9kBgFnVekohm75878JOg@mail.gmail.com
Whole thread Raw
Responses Re: [pgAdmin][RM5815] Generate script is not working in new window
List pgadmin-hackers
Hi Hackers,

If schema diff is opened in a new tab and "Generate script" is clicked (with query tool setting "open in new tab" set to true) then it shows a forever spinner because of pop up blocks.

Attached patch will show an alert message in that case so that the user can allow pop up and generate the script again.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed an issue while refreshing Resource Group. Fixes
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Fixed an issue where vacuum options not consider in S