Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting
Date
Msg-id CANxoLDdqNE_5VGmHah55LchdQXjL88OqjJCasCQ57SdpmeBmQA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Aditya

I have tried your patch on MAC. Backup job is completed successfully but got the following message:
pg_dump: last built-in OID is 16383
pg_dump: no matching schemas were found

Please verify it once again and send the modified patch. 

On Tue, Oct 8, 2019 at 5:46 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Turned out to be an issue only on Mac. Backup works fine for other OS.
Attached is the patch to fix the issue on Mac. Code is changed to add extra pairs of quotes wherever required on MacOS.

Kindly review.

On Thu, Oct 3, 2019 at 3:53 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the schema backup with names that requires double quotes.
Command line has special meaning for double quotes and so the command is run without the double quotes if applied on objects. Code is changed to add extra pairs of quotes to save our object quotes.

Also fixed a test case which was failing if certain paths had spaces in between.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM4701] Webpack optimization
Next
From: Aditya Toshniwal
Date:
Subject: Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting