Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting
Date
Msg-id CAM9w-_=NNvVYKu4U1C1vALQ6dJjjkWy9NztcURvoy7yb9SWobA@mail.gmail.com
Whole thread Raw
In response to [pgAdmin][RM4590] Schema Backup fails with names that requires quoting  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Hackers,

Turned out to be an issue only on Mac. Backup works fine for other OS.
Attached is the patch to fix the issue on Mac. Code is changed to add extra pairs of quotes wherever required on MacOS.

Kindly review.

On Thu, Oct 3, 2019 at 3:53 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch to fix the schema backup with names that requires double quotes.
Command line has special meaning for double quotes and so the command is run without the double quotes if applied on objects. Code is changed to add extra pairs of quotes to save our object quotes.

Also fixed a test case which was failing if certain paths had spaces in between.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin 4 commit: Fixes # 4778 - Implement the query plan analyzer
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Feature test should work with Python 2.7.