Postgres Pro
Downloads
Home   >   mailing lists

Re: [4696] Add RE-SQL/MSQL test cases for Materialized View - Mailing list pgadmin-hackers

From Akshay Joshi
Subject Re: [4696] Add RE-SQL/MSQL test cases for Materialized View
Date
Msg-id CANxoLDdGpuCZu1up5=Ue0hTJkVQDVsxWMH3zH8NKBa6k-zMxtg@mail.gmail.com
Whole thread Raw
In response to [4696] Add RE-SQL/MSQL test cases for Materialized View  (Fahar Abbas <fahar.abbas@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi Fahar

Below are the review comments:
  • Align test_msql.json file properly.
  • Give meaningful scenario names like "Alter MView comment, acl etc.."
  • Data for create and alter are identical, i am not sure what exactly you have changed.
  • Create/Alter test cases missing for With Data?, Tablespace, Fill factor, Table, Toast Table, Privileges. (Cover maximum controls.)

On Thu, Sep 5, 2019 at 1:39 PM Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Hi Hackers,

Please find attached the patch for RE-SQL for Materialized view.

Please review and apply the patch.

Will send MSQL patch later.

Kind Regards,
--
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: live:fahar.abbas
Website: www.enterprisedb.com


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

pgadmin-hackers by date:

Previous
From: Fahar Abbas
Date:
Subject: [4696] Add RE-SQL/MSQL test cases for Materialized View
Next
From: Dave Page
Date:
Subject: Re: [4696] Add RE-SQL/MSQL test cases for Materialized View